diff --git a/extensions/mssql/l10n/bundle.l10n.json b/extensions/mssql/l10n/bundle.l10n.json index 71d9c3f369..47ff1cb6fd 100644 --- a/extensions/mssql/l10n/bundle.l10n.json +++ b/extensions/mssql/l10n/bundle.l10n.json @@ -244,6 +244,8 @@ "message": "{0} of {1} rules", "comment": ["{0} is the filtered count, {1} is the total count"] }, + "Rule enabled": "Rule enabled", + "Rule disabled": "Rule disabled", "Create new firewall rule for {0}/{0} is the server name that the firewall rule will be created for": { "message": "Create new firewall rule for {0}", "comment": ["{0} is the server name that the firewall rule will be created for"] diff --git a/extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts b/extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts index 722bd1f2c0..3a1f9e54bc 100644 --- a/extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts +++ b/extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts @@ -169,7 +169,6 @@ export class CodeAnalysisWebViewController extends ReactWebviewPanelController< } if (payload.closeAfterSave) { this.vscodeWrapper.logToOutputChannel(Loc.rulesSaved); - this.vscodeWrapper.outputChannel.show(); this.panel.dispose(); } // Update the baseline rules so the component's useEffect resets isDirty diff --git a/extensions/mssql/src/reactviews/common/locConstants.ts b/extensions/mssql/src/reactviews/common/locConstants.ts index de5ae7d776..dcb2864d46 100644 --- a/extensions/mssql/src/reactviews/common/locConstants.ts +++ b/extensions/mssql/src/reactviews/common/locConstants.ts @@ -265,6 +265,8 @@ export class LocConstants { args: [filtered, total], comment: ["{0} is the filtered count, {1} is the total count"], }), + ruleEnabled: l10n.t("Rule enabled"), + ruleDisabled: l10n.t("Rule disabled"), }; } diff --git a/extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx b/extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx index 65aad30b6a..d4b64c427c 100644 --- a/extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx +++ b/extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx @@ -32,6 +32,7 @@ import { ChevronDown20Regular, ChevronRight20Regular, Search20Regular, + Checkmark20Regular, } from "@fluentui/react-icons"; import { DialogHeader } from "../../common/dialogHeader.component"; import { DialogMessage } from "../../common/dialogMessage"; @@ -115,6 +116,14 @@ const useStyles = makeStyles({ gap: "8px", paddingLeft: "56px", }, + checkmarkContainer: { + width: "20px", + height: "20px", + display: "flex", + alignItems: "center", + justifyContent: "center", + flexShrink: 0, + }, // --- States --- spinnerContainer: { @@ -487,13 +496,20 @@ export const CodeAnalysisDialog = () => {
- +
+ {rule.enabled && ( +
{rule.shortRuleId}:{" "} {rule.displayName} diff --git a/extensions/sql-database-projects/package.nls.json b/extensions/sql-database-projects/package.nls.json index 67b236c8f9..f563a4f7fc 100644 --- a/extensions/sql-database-projects/package.nls.json +++ b/extensions/sql-database-projects/package.nls.json @@ -11,7 +11,7 @@ "sqlDatabaseProjects.publish": "Publish", "sqlDatabaseProjects.createProjectFromDatabase": "Create Project From Database", "sqlDatabaseProjects.updateProjectFromDatabase": "Update Project From Database", - "sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings (Preview)", + "sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings", "sqlDatabaseProjects.properties": "Properties", "sqlDatabaseProjects.schemaCompare": "Schema Compare", "sqlDatabaseProjects.delete": "Delete", diff --git a/localization/xliff/sql-database-projects.xlf b/localization/xliff/sql-database-projects.xlf index eb030fa540..d46093b8de 100644 --- a/localization/xliff/sql-database-projects.xlf +++ b/localization/xliff/sql-database-projects.xlf @@ -994,7 +994,7 @@ Close Database Project - Code Analysis Settings (Preview) + Code Analysis Settings Convert to SDK-style project diff --git a/localization/xliff/vscode-mssql.xlf b/localization/xliff/vscode-mssql.xlf index 922321b90c..1282ee897e 100644 --- a/localization/xliff/vscode-mssql.xlf +++ b/localization/xliff/vscode-mssql.xlf @@ -4961,6 +4961,12 @@ Rows per page + + Rule disabled + + + Rule enabled + Rule name