fixing the tests

Author: ssreerama

extensions/sql-database-projects/src/http/httpClientCore.ts

@@ -131,7 +131,10 @@ export class HttpClientCore {
         }
 
         await new Promise<void>((resolve, reject) => {
-            const tmpFile = fs.createWriteStream("", { fd: destinationFd });
+            // autoClose: false keeps fd ownership with the caller (who calls fs.closeSync in finally).
+            // Without it, pipe's automatic end() would trigger auto-close of the fd,
+            // causing the caller's fs.closeSync to throw EBADF.
+            const tmpFile = fs.createWriteStream("", { fd: destinationFd, autoClose: false });
 
             const cleanup = (err: NodeJS.ErrnoException) => {
                 // Destroy both streams to avoid file-descriptor leaks and stalled pipes
@@ -148,9 +151,8 @@ export class HttpClientCore {
             tmpFile.on("error", cleanup);
 
             // Resolve only after the WriteStream has fully flushed to disk.
-            // Using pipe without { end: false } so that the WriteStream is
-            // automatically ended when the response stream finishes, which
-            // triggers the 'finish' event once all bytes have been written.
+            // pipe automatically calls tmpFile.end() when the response stream finishes,
+            // which triggers the 'finish' event once all bytes have been written.
             tmpFile.on("finish", resolve);
 
             response.data.pipe(tmpFile);

extensions/sql-database-projects/test/httpClient.test.ts

@@ -468,7 +468,6 @@ suite("HttpClient tests", () => {
 
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
             sandbox.stub(httpClient as any, "createProxyAgent").returns({
-                isHttps: true,
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 agent: {} as any,
             });
@@ -493,16 +492,16 @@ suite("HttpClient tests", () => {
 
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
             sandbox.stub(httpClient as any, "createProxyAgent").returns({
-                isHttps: false,
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 agent: {} as any,
             });
 
             const result = httpClient["setupConfigAndProxyForRequest"](requestUrl, token);
 
             expect(result.proxy).to.be.false;
-            expect(result.httpAgent).to.exist;
-            expect(result.httpsAgent).to.be.undefined;
+            // HTTPS request URL → httpsAgent, regardless of proxy scheme
+            expect(result.httpsAgent).to.exist;
+            expect(result.httpAgent).to.be.undefined;
         });
 
         test("should log when proxy is found", () => {
@@ -518,7 +517,6 @@ suite("HttpClient tests", () => {
 
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
             sandbox.stub(httpClient as any, "createProxyAgent").returns({
-                isHttps: false,
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 agent: {} as any,
             });