Skip to content

Commit be2fa21

Browse files
Yu Leng (from Dev Box)claude
andcommitted
chore(spell-check): allowlist PowerDisplay discovery terms and reword forbidden patterns
Resolves the check-spelling failure on the discovery-pipeline branch: - expect.txt: add agentic, followups, threadpool, UIDs, yuleng, Zenbook - verification doc: shorten commit SHA range to 7-char form (drops `fdb` token), move period inside parenthetical, "pre-existing" -> "preexisting" - plan doc: add "that" to avoid the article-noun-article forbidden pattern Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0fcfb0b commit be2fa21

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/actions/spell-check/expect.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ advfirewall
2626
AFeature
2727
affordances
2828
AFX
29+
agentic
2930
agentskills
3031
AGGREGATABLE
3132
AHK
@@ -572,6 +573,7 @@ FOF
572573
FOFX
573574
FOLDERID
574575
folderpath
576+
followups
575577
FONTTYPE
576578
FORCEFILESYSTEM
577579
FORCEMINIMIZE
@@ -1856,6 +1858,7 @@ themeresources
18561858
THH
18571859
thickframe
18581860
THISCOMPONENT
1861+
threadpool
18591862
throughs
18601863
TILEDWINDOW
18611864
TILLSON
@@ -1911,6 +1914,7 @@ ucrtd
19111914
uefi
19121915
uesc
19131916
UIA
1917+
UIDs
19141918
UIEx
19151919
uild
19161920
uitests
@@ -2149,8 +2153,10 @@ xxxxxx
21492153
ycombinator
21502154
yinle
21512155
yinyue
2156+
yuleng
21522157
YVIRTUALSCREEN
21532158
zamora
2159+
Zenbook
21542160
ZEROINIT
21552161
zonability
21562162
zonable

docs/superpowers/plans/2026-05-11-powerdisplay-discovery-pipeline.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ Switch the orchestrator from three sequential phases to one `Task.WhenAll` over
601601
602602
## Task 6: Manual verification
603603
604-
The 86 unit tests don't exercise `DiscoverMonitorsAsync` (they cover `DisplayClassifier` only). Functional correctness must be verified by running the app against real hardware. This task has no code steps — it's a checklist the implementer (or a reviewer) runs after the refactor commits land.
604+
The 86 unit tests don't exercise `DiscoverMonitorsAsync` (they cover `DisplayClassifier` only). Functional correctness must be verified by running the app against real hardware. This task has no code steps — it's a checklist that the implementer (or a reviewer) runs after the refactor commits land.
605605
606606
**Files:** none.
607607

docs/superpowers/verification/2026-05-11-powerdisplay-discovery-pipeline-verification.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# PowerDisplay Discovery Pipeline — Manual Verification
22

33
**Date**: 2026-05-11
4-
**Scope**: Verify the per-monitor pipeline refactor of `DdcCiController.DiscoverMonitorsAsync` (commits `e6ec90fdb2..13e34836d9`)
4+
**Scope**: Verify the per-monitor pipeline refactor of `DdcCiController.DiscoverMonitorsAsync` (commits `e6ec90f..13e3483`)
55
**Related**:
66
- Spec: [../specs/2026-05-11-powerdisplay-discovery-pipeline-design.md](../specs/2026-05-11-powerdisplay-discovery-pipeline-design.md)
77
- Plan: [../plans/2026-05-11-powerdisplay-discovery-pipeline.md](../plans/2026-05-11-powerdisplay-discovery-pipeline.md)
@@ -148,7 +148,7 @@ T2 No blocking sleep: Pass / Fail / Inconclusive
148148

149149
If something fails, the most actionable signals:
150150

151-
1. **Perf is worse than baseline** → confirm Release|x64 build (Debug builds are dramatically slower). Then check log for repeated retries (e.g., `GetPhysicalMonitors attempt 2 retrying`) — if a single hMonitor retries 3× × 200 ms, that's an extra 400 ms per pipeline.
151+
1. **Perf is worse than baseline** → confirm Release|x64 build; Debug builds are dramatically slower. Then check log for repeated retries (e.g., `GetPhysicalMonitors attempt 2 retrying`) — if a single hMonitor retries 3× × 200 ms, that's an extra 400 ms per pipeline.
152152

153153
2. **Discovery completes but monitor count is wrong** → check log for:
154154
- `Failed to get GDI device name for hMonitor=0x...`
@@ -158,7 +158,7 @@ If something fails, the most actionable signals:
158158

159159
3. **App crashes / hangs during discovery** → grab a dump. Most likely candidates:
160160
- Win32 `CapabilitiesRequestAndCapabilitiesReply` hung at firmware level (out of scope, monitor-specific)
161-
- Deadlock in `_handleManager.UpdateHandleMap` lock (the lock semantics are unchanged from pre-refactor, so this would be a pre-existing bug surfaced by parallel timing)
161+
- Deadlock in `_handleManager.UpdateHandleMap` lock (the lock semantics are unchanged from pre-refactor, so this would be a preexisting bug surfaced by parallel timing)
162162

163163
4. **`OperationCanceledException` shows up in log unexpectedly** → check that the consumer isn't canceling the token early. `MainViewModel.RefreshMonitorsAsync` shouldn't cancel its own request; if it does, that's a separate bug.
164164

0 commit comments

Comments
 (0)