fix(security): 2 improvements across 1 files#252
Open
tomaioo wants to merge 1 commit into
Open
Conversation
- Security: Potential Prototype Pollution in Template Token Binding - Security: Unsafe innerHTML Assignment in Custom Element Template Processing Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
@tomaioo is attempting to deploy a commit to the sneakyhead's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
Medium| File:dist/snuggsi.min.es.js:L1The TokenList.bind method iterates over all properties of an object using
for...inwithout checking hasOwnProperty, which could lead to prototype pollution if malicious data is passed. Thebindmethod in both minified files usesfor(let n in this)and then filters with"bind"!=n, but this doesn't prevent other inherited properties from being processed.Solution
Add hasOwnProperty checks in the bind method to ensure only own properties are processed. Sanitize the token names to prevent prototype pollution attacks.
Changes
dist/snuggsi.min.es.js(modified)