🐛 plugins aren't resolved from the location of the config file

[adamhl8]

Environment information

CLI:
  Version:                      2.0.6
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  BIOME_THREADS:                unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           v22.6.0
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         bun/1.2.17

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         biome.jsonc
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

What happened?

Say you have a setup like this:

./configs/biome.json

{
  "root": false,
  "plugins": ["./pattern.grit"],
}

./biome.json

{
  "extends": ["./configs/biome.json"]
}

Run biome check:

  ✖ Error(s) during loading of plugins:
    Cannot read file.

Changing the plugin path to be relative to the root config makes it work:

./configs/biome.json

{
  "root": false,
  "plugins": ["./configs/pattern.grit"],
}

Plugins should be resolved relative to the specifying config.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

That's how all paths work, not just the one that belongs to the plugin.

Not sure if we should categorise this as a bug, but if we changed this, we would need to change the resolution of paths as well e.g. files.includes

[github-actions]

Hello @adamhl8, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

[arendjr]

I think we could choose to have an exception for plugins, which to me make some sense given that it’s a different use case and configs that are being extended wouldn’t reasonably know the location of plugins relative to the config they are being extended from.

That said, I’m not entirely sure yet we should make this change. And definitely agreed it’s not a bug, so l’ll convert this to a discussion for now.