eslint-plugin-react-you-might-not-need-an-effect

[NOBLES5E]

So that we can easily catch unnecessary React useEffects

https://github.com/NickvanDyke/eslint-plugin-react-you-might-not-need-an-effect

[ematipico]

Not sure. What are the heuristics of the rule?

[NOBLES5E]

@ematipico From my basic understanding:

1. Empty effects - useEffect(() => {}) with no body
2. Initializing state in effects - useEffect(() => setState(x), []) instead of useState(x)
3. Deriving state from props/state - calculating values in effects that could just be computed during render
4. Chaining state updates - useEffect(() => setB(x), [a]) where you could update both together
5. Adjusting state on prop change - similar but specifically when deps are all props
6. Resetting all state on prop change - when you could use key prop instead
7. Event handlers disguised as effects - useEffect(() => { if (condition) doThing() }, [condition])
8. Passing data to parent - calling parent callbacks with derived data in effects
9. Passing live state to parent - notifying parents of state changes via effects
10. Managing parent logic - effects that only use props (logic should be in parent)

Would any of these make sense to integrate into Biome's lint rules? The patterns are pretty common footguns, and having them built-in would be helpful.

[lzcmian]

This is definitely useful! I've noticed that my Claude Code tends to write this kind of anti-pattern code quite easily.