chore: use ruff to lint and format files and apply fixes#3779
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces isort and black with ruff for linting and formatting across the repository, leading to extensive automated changes in imports and code style. While the transition modernizes the project's tooling, the automated cleanup removed several imports required for tests to function correctly, specifically in system_python_nodeps_test.py, repl_test.py, and verify_files_test.py. The reviewer also identified a version typo in the pre-commit configuration and recommended lowering the target-version in ruff.toml to maintain support for older Python versions.
dougthor42
approved these changes
May 16, 2026
Collaborator
dougthor42
left a comment
dougthor42
left a comment
There was a problem hiding this comment.
Most of the AI comments are actually decent. One wasn't.
+2 when those are addressed.
aignas
force-pushed
the
aignas.refactor.pre-commit-use-ruff
branch
from
3e59864 to
e3b9858
Compare
aignas
force-pushed
the
aignas.refactor.pre-commit-use-ruff
branch
from
3cfb59d to
c8b200f
Compare
aignas
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a few attempts at doing these, but the efforts are
stale. Since
ruffis very popular these days and it is only a singlebinary and is fast, let's use that.
From now on we will be able to maintain the files better, because we
have a CI step testing the compliance.
Closes #3073