CASSANDRA-21398: Add agent skills for property / stateful testing#4837
Open
dcapwell wants to merge 13 commits into
Open
CASSANDRA-21398: Add agent skills for property / stateful testing#4837dcapwell wants to merge 13 commits into
dcapwell wants to merge 13 commits into
Conversation
dcapwell
commented
May 22, 2026
| * Generates a random byte array whose size is determined by the given size generator. | ||
| * Fills 8 bytes at a time using {@code nextLong()} for efficiency, then fills any remaining bytes individually. | ||
| */ | ||
| public static Gen<byte[]> byteArray(Gen.IntGen sizeGen) |
Contributor
Author
There was a problem hiding this comment.
didn't have a good place to put this... i really need to get rid of QuickTheories...
dcapwell
commented
May 22, 2026
| for (int i = start ; i < end ; ++i) | ||
| { | ||
| char c = hex.charAt(i); | ||
| result |= (long)(c - (c >= 'a' ? 'a' - 10 : '0')) << shift; |
Contributor
Author
There was a problem hiding this comment.
hex includes upper case but this method doesn't handle that. This is fine in existing usage as we use Long.toHexString(lsb); which explicitly documents that its lower case only (if you want upper case it says to do toUpperCase).
So this bug fix isn't for any existing logic, but more defensive to make sure future logic works correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.