Skip to content

[v2] Fix OnyxDataGrid feature order for modifyColumns #5424

@larsrickert

Description

@larsrickert

Why?

Currently, there is an inconsistent behavior how feature mutation.

While mutations, enhanceCells and enhanceRows are sorted largest to smallest (

), modifyColumns are sorted smallest to largest:
.sort((a, b) => (a?.order ?? 0) - (b?.order ?? 0));

To prevent a breaking change for the user, we will delay this fix until onyx version 2.

Acceptance criteria

  • modifyColumns is fixed to also sort largest to smallest

DEV handover checklist

Storybook

DEV handover done with: @ADD_DEV_NAME_HERE

Testing

  • covered by visual screenshot tests
  • covered by functional tests (Playwright or unit test)

Documentation

Other

  • follow-up tickets were created if necessary (add links below)

Metadata

Metadata

Assignees

Labels

0-refinementAll issues that can or need to be estimated in our next refinementdevRequires technical expertise

Type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions