feat(code): Restore signals onboarding inside the Inbox view#2376
Merged
Conversation
PR #2208 dropped the signals step from app onboarding to improve conversion, but the setup UX it removed never landed anywhere else — users with no GitHub or no signal sources just saw a stripped-down WelcomePane that bounced them into a modal. Replaces that empty state with an inline InboxSetupPane that mirrors the deleted SignalsStep (hero copy, detective hog tip, animated entrance) and embeds SignalSourcesSettings so users get GitHub connect, source toggles, PR auto-start threshold, and Slack notifications without leaving the Inbox. Warming-up state and the configuration dialog (still opened from the toolbar and auto-open effect) are unchanged. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
Contributor
|
Reviews (1): Last reviewed commit: "feat(code): Restore signals onboarding i..." | Re-trigger Greptile |
Previously the inline setup pane only appeared in the existing empty-state branch, so a user with discovered/suggested tasks (but no real signal reports and no sources configured) was pushed into the two-pane RecommendedSetupTasks view and never saw the onboarding. Lifts the onboarding to a top-level branch ahead of two-pane and changes the condition to `!hasReports && !hasSignalSources`. Suggested tasks alone no longer skip a source-less user past setup. The GitHub-only-missing case now falls through to two-pane or warming-up, where the existing InboxSourcesDialog auto-open continues to prompt when totalCount > 0. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
…rding The inline setup pane already is the configuration UI, so the toolbar shortcut that opens InboxSourcesDialog over the top of it was a duplicate, redundant path. Drop the onConfigureSources prop on the toolbar in the onboarding branch. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
…ltip Three changes on top of the inline Inbox onboarding: - Bigger subtext: bump the InboxSetupPane description from text-sm to text-base leading-relaxed so the explanation reads as a clear hero paragraph rather than fine print. - Hide search bar in onboarding: add a hideSearch prop to SignalsToolbar and pass it in the onboarding render. The search row makes no sense before any reports exist. - Sticky onboarding within a visit + revisit teaching tooltip: onboarding no longer flips off the instant a source is toggled on. An onboardingStickyRef latches true on first entry and unwinds naturally when InboxView unmounts on navigation away. A new persisted store (inboxOnboardingStore) tracks hasSeenOnboarding and hasDismissedConfigTooltip in localStorage. On the next inbox visit after onboarding, the Configure sources toolbar button shows a persistent Radix tooltip "All of your Inbox configuration is here" (side=bottom, align=end). Opening the InboxSourcesDialog by any path — manual click or the existing totalCount>0 auto-open — dismisses the tooltip permanently. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
The report counter, search, and bulk-actions row are all meaningless before any source is configured. Render only the InboxSetupPane inside a ScrollArea during onboarding. Drop the now-unused hideSearch prop on SignalsToolbar. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
Twixes
force-pushed
the
posthog-code/restore-signals-onboarding-in-inbox
branch
from
0be8c4b to
963a87c
Compare
The TextField→TextArea + Cmd/Ctrl+Enter change in ReportDetailPane was unrelated to the Inbox onboarding restoration and got bundled into an earlier commit on this branch by mistake. Reverting it back to main. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
Drop the sticky-within-visit + persistent tooltip behavior. The full-page InboxSetupPane shows only while !hasReports && !hasSignalSources; the instant that condition turns false (user enables their first source), the InboxSourcesDialog modal pops automatically so the user can keep configuring with the inbox visible underneath. Removes the now-unused inboxOnboardingStore and the configSourcesTooltipOpen plumbing on SignalsToolbar. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
…scape hatch Once a user enters the Inbox onboarding view in a session, keep them there until they either navigate away (natural unmount reset) or click the new "Proceed to Inbox" button in the bottom-right of the setup pane. Replaces the auto-pop-the-sources-dialog behavior. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
…ate on source The escape-hatch button now lives at the bottom of the InboxSetupPane flex column (right-aligned) instead of an absolute-positioned overlay, and it's disabled until at least one signal source is enabled — with a "Disabled because Enable at least one source first" tooltip via the shared Button's disabledReason mechanism. Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
Generated-By: PostHog Code Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
charlesvien
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #2208 dropped the signals step from app onboarding to improve conversion, completely. Users with no GitHub or no signal sources just saw an empty
WelcomePanein the Inbox, no config, no onboarding.Changes
Restoring
InboxSetupPanemirroring the deletedSignalsStepdesign, that reusesSignalSourcesSettings.(also makes the buttons non-red for @annikaschmid, and actually switched to @adamleithp's Quill)
I think the better onboarding flow is something like:
– but a good splash screen will take a little bit of work, so preferring to just restore for now.
Publish to changelog?
no